nzw921rx commented on PR #11791:
URL: https://github.com/apache/seatunnel/pull/11791#issuecomment-5378836372
Thanks for pointing this out. I checked the actual container selection logic
in `ContainerUtil.discoverTestContainers()`.
The relevant branch is:
```java
if (testAllContainer
|| container.identifier().equals(FLINK_1_18)
|| container.identifier().equals(FLINK_1_20)
|| container.identifier().equals(SPARK_3_3)) {
return true;
}
if (testZetaContainer) {
return container
.identifier()
.getEngineType()
.equals(EngineType.SEATUNNEL);
}
return true;
```
So when both `RUN_ALL_CONTAINER` and `RUN_ZETA_CONTAINER` are `false`, the
logic falls through to the final `return true`, which means the container is
still included rather than skipped.
Based on this, direct Iceberg/HBase module changes should not reduce the E2E
container coverage in the double-false case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
