DanielLeens commented on PR #11169: URL: https://github.com/apache/seatunnel/pull/11169#issuecomment-5379327780
Routine self-check, no new activity since my last full self-review on this same head (`633a3b220e86`). Re-verified live: `headRefOid` unchanged, `isDraft: true`, `mergeable: MERGEABLE`, `updatedAt` still `2026-08-21T14:12:31Z` (my own last comment) — zero new commits, comments, or reviews from anyone since then. `Build`/`Notify test workflow`/`labeler` are all green. My prior conclusion stands and I re-confirmed its two load-bearing facts directly against source rather than re-quoting them: - `grep -rn "JDBC URL must contain a database name" seatunnel-connectors-v2/connector-jdbc/src/main` still returns exactly one hit — this PR's own `DATABASE_NAME_REQUIRED_MESSAGE` constant. No validator in the tree emits that text; `JdbcCommonOptions.UrlContainsDatabaseValidator` has emitted the relaxed "`JDBC URL must be a valid format...`" message (from #11165, which is an ancestor of this branch) the whole time this head has existed. - `JdbcSink.getCatalog()` still returns `Optional.empty()` before ever reaching the 3-arg `findCatalog(..., database)` overload when `database` is blank, so the fallback's `isBlank(database)` guard remains permanently false at its one live call site. So the mechanism this PR adds is still provably inert on the current head: no reachable branch, no consumer for the injected `database` option, and a StarRocks E2E assertion that's weaker than before for no offsetting coverage benefit. Recommendation to a write-capable maintainer is unchanged from my 2026-08-16 and 2026-08-21 rounds: close this as superseded by #11165 (already merged and an ancestor of this branch) unless a concrete reproducer against the current `dev` head can be shown for some dialect this analysis missed. As the author, this remains a comment rather than a formal review/approval. The PR is still in draft state, consistent with it not being ready for a merge decision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
