DanielLeens commented on PR #11754: URL: https://github.com/apache/seatunnel/pull/11754#issuecomment-5379749564
One more concrete item on top of the two still-open from my last comment (docs update + unit test for the `TEXT` branch): the fork's CI is currently failing on **`Run / Code style`**, and it's a real, directly-diff-related failure, not an infra fluke. `./mvnw spotless:check` fails on the exact method this PR touches: ``` [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.29.0:check (default-cli) on project connector-pulsar: The following files had format violations: [ERROR] src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/source/PulsarSource.java [ERROR] @@ -203,7 +203,8 @@ [ERROR] ····························createDeserialization( [ERROR] ····································tableConfig.getFormat(), [ERROR] ····································catalogTable, [ERROR] -····································tableConfig.getSchemaConfig() [ERROR] +····································tableConfig [ERROR] +············································.getSchemaConfig() [ERROR] ············································.get(PulsarSourceOptions.FIELD_DELIMITER)), ``` That's a pure formatting nit (line-wrap of the new `createDeserialization(...)` call), not a logic issue — running `./mvnw spotless:apply` locally and pushing the result should clear it. Once you're pushing a new commit anyway, it'd be efficient to fold in the doc fix and the unit test from my previous comment at the same time. Separately, the branch currently shows a merge conflict against `dev` (unrelated to this Spotless failure) — worth rebasing before the next push so the CI run is clean end to end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
