SEZ9 commented on issue #11610: URL: https://github.com/apache/seatunnel/issues/11610#issuecomment-5381235341
@goutamadwant Thanks for the detailed follow-up, and answering it directly here since it was still open. Small note: I think the mention in your comment was meant for me — I'm the one who reviewed this thread. To answer your points: yes, what you describe covers the failure mode reported here. Excluding the edge-agent archive, requiring exactly one regular distribution, and validating `bin/seatunnel.sh` and `bin/seatunnel-cluster.sh` after extraction (with a clear "Missing required file" failure for malformed archives) matches the review boundary I set out earlier. The focused test coverage for regular-plus-edge-agent, zero regular archives, and multiple regular archives is exactly the right set of cases, and your local pass of the focused runner test is good news. Nothing more is needed from you on the design side. The remaining concrete asks before we can close this: 1. Sync the branch and rerun CI on PR #11611, as you proposed, and confirm here once it reaches a terminal green state. 2. After merge, run the upgrade-compatibility validation with `scenario=all` on `dev` and post confirmation that it reaches the generic and MySQL CDC restore scenarios, not just the archive lookup step. Once both are confirmed, this issue can be closed as fixed in `dev`. Thanks for driving this to completion. <!-- streview-comment:442 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
