SEZ9 commented on PR #10583: URL: https://github.com/apache/seatunnel/pull/10583#issuecomment-5381239417
Thanks @DanielLeens for the thorough re-review, and for tracing the three-dot diff to confirm the head-vs-`dev` change is still Javadoc-only on `MultiTableWriterRunnable` — that extra check on the seemingly alarming two-commit diff (`32a1dafbbc4..98e0832aec2`) was exactly the right call. Good to see the branch has now been synced with `dev` via `cf1aa3192c`, which was the main ask from my last comment. Your note that `git diff 98e0832aec2..HEAD` on the file returns empty also confirms the content you approved earlier is unchanged on the current head `cf1aa3192cfac371c1d5090291bd322692779a8f`. The one remaining item is the same as before: a green `Build` run on the current head. You've assessed the current failure as a Maven Central infrastructure flake unrelated to this diff, which sounds plausible for a comment-only change — but I'd still like to see it pass rather than merge over a red lane. Concretely: 1. Please retrigger CI on `cf1aa3192c` (an empty retrigger commit like the earlier `32a1dafbb` is fine if needed). 2. Once `Build` is green on that head, ping here and we can merge. Nothing else outstanding from my side — thanks again for the careful verification work. <!-- streview-comment:455 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
