SEZ9 commented on PR #10472: URL: https://github.com/apache/seatunnel/pull/10472#issuecomment-5390956806
Thanks @DanielLeens — your summary of the current state is accurate, and I agree with both points. 1. Source-review side: settled. The `CHAR`/`VARCHAR` raw-length path and the x4 Unicode conversion limited to `NVARCHAR`/`SHORTTEXT` is the correct mapping given SAP HANA treats `CHAR` as single-byte ASCII. No further changes to `convert()` are needed. 2. CI/merge mechanics: nothing has been done yet on this — the branch head is unchanged, so the failing run you referenced (https://github.com/dik111/seatunnel/actions/runs/30203290621/job/89797481903) is still the latest signal. I agree those failures look stale/unrelated to this SAP HANA diff, and we should not patch unrelated engine or integration-test code here. Concrete remaining asks, all on the branch owner's side: - Sync the branch with the latest `dev` and push the updated head. - Rerun `Build` on the synced head. - If it still fails after the sync, share the new failing check link so we can narrow it down against the updated head. Once the synced head is pushed, a fresh full review pass against it (as you proposed) sounds right, since the merge could shift line numbers or touch adjacent code. Note @davidzollo has already given a +1 conditional on CI passing, so a green `Build` on the synced head is the last gate before merge. Thanks for keeping this tracked! <!-- streview-comment:497 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
