SEZ9 commented on PR #11069:
URL: https://github.com/apache/seatunnel/pull/11069#issuecomment-5390958279

   @DanielLeens Thanks for laying out the concrete asks so clearly — confirming 
alignment on all three:
   
   1. **Sync with `dev`** — not done yet. The branch is still at `29c3f664f70b` 
with the merge conflicts unresolved, so this remains the first step before 
anything else lands.
   2. **Wrap `OffsetDateTime.parse` in `convertToTimestampTz()`** — agreed this 
is blocking. Rethrowing with the column name plus the raw value addresses the 
asymmetry you described between the two failure branches; still to be done.
   3. **Docs update** — agreed. The `TIMESTAMP_TZ` mapping needs to be added to 
`docs/en/connector-v2/source/Postgres-CDC.md` and the zh counterpart in the 
same pass; also still outstanding.
   
   So to be plain: none of the three have landed yet, and the plan is to 
deliver them together in a single push, with Issues 2 and 4 folded in where 
feasible as non-blocking improvements. Your suggested sequence makes sense — 
rebase first so CI signal is attributable to this diff rather than the stale 
base.
   
   Appreciate the offer of a full fresh review of the whole head once the push 
lands; that's the right call given how much has moved on `dev`. We'll follow up 
here when the refreshed branch is up. Thanks for staying so thorough on this 
one.
   
   <!-- streview-comment:505 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to