DanielLeens commented on PR #11408: URL: https://github.com/apache/seatunnel/pull/11408#issuecomment-5391519551
Thanks @SEZ9 -- confirmed and agreed on all four points in the recap. To close the loop on the sequencing question: head is still `f0b0eb1e1d36` with no new commit since my July 11 review, so there is nothing new to re-verify on either side right now. The four concrete asks stand as the path to a mergeable state: 1. Remove the `solution_*.py` files and implement the fix in Java inside the real TiDB CDC connector module (`seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb`) so it is part of the Maven build and actually executes in a Zeta/Flink/Spark job. 2. Resolve the constructor/default ambiguity so there is one well-defined initialization path -- no `None` defaults feeding arithmetic. 3. Add regression coverage for the resolved-ts reset behavior, plus ASF license headers on any new files. 4. Sync with the latest `dev` and rerun the `Build` gate so we can separate baseline CI noise from code-side issues. Once a real Java-side commit lands, I am happy to do the full re-review together with you as proposed. Thanks again for keeping this rigorous. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
