zhang-arvin commented on PR #11843:
URL: https://github.com/apache/seatunnel/pull/11843#issuecomment-5392989814
@DanielLeens thank you for the incredibly detailed and patient review
through all six rounds! You were absolutely right — the branch had been
force-pushed back to a stale snapshot from round 3, discarding all the round
4-6 fixes. I've now:
1. Reset the branch to current `origin/dev` (406c6678)
2. Re-applied the correct round-6 approach:
- Added `DM_NVARCHAR2` constant
- Added `case DM_NVARCHAR2:` to the existing dynamic `case DM_NCHAR: case
DM_NVARCHAR:` block (keeping the `dmType` echo, no hardcoded constant)
- Added `testNvarchar2()` without modifying `testNvarchar()`
3. Rebased onto latest `dev` — no merge conflicts, `DM_NCHAR` support from
#11860 is preserved
The fix is now 2 lines in `DmdbTypeConverter.java` + 16 lines of new test,
exactly as you described in round 6's "Best improvement" suggestion. The
`sourceType` correctly echoes `dmType` dynamically, and `testNvarchar()` still
tests plain `NVARCHAR` input.
Please take another look when you have time. Apologies for the
back-and-forth — lesson learned on force-push hygiene!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
