DanielLeens commented on issue #11878:
URL: https://github.com/apache/seatunnel/issues/11878#issuecomment-5394997681

   Thanks for writing the design answers out in this level of detail. The 
clarified direction looks reasonable to me now.
   
   The important parts are:
   1. `primary_keys` keeps its current legacy contract unchanged;
   2. the new per-table mapping lives under a separate `multi_table_config` 
scope;
   3. pattern evaluation is explicit and deterministic;
   4. tables with no match fall back to the existing `primary_keys` behavior.
   
   I think this is now ready for a focused PR, but please make three things 
explicit in the PR description and tests:
   1. first-match-wins semantics for overlapping patterns;
   2. no-match fallback to the legacy `primary_keys` path;
   3. `${primary_key}` expansion is only defined inside `multi_table_config` 
and does not change the old `primary_keys` contract.
   
   Please also cover the generated-SQL path, auto-created tables, and matching 
English/Chinese docs in the same PR. Once the PR is up, link it back here so 
maintainers can review the exact option shape and edge-case coverage together.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to