DanielLeens commented on PR #11885: URL: https://github.com/apache/seatunnel/pull/11885#issuecomment-5396361116
Quick follow-up on my approval above. At the time I approved (commit a090452, same head as now), the fork's `Build` check was showing `FAILURE`, but the only failing test in that run was `PostgresCDCIT.testPostgresCdcSnapshotOnlyAndCommittedOffsetStartupModes`, an unrelated Postgres-CDC committed-offset/restore issue already tracked in #11847 (fix pending in #11864) - not caused by this PR's MySQL-only diff. Since then, CI was rerun on this exact same head commit and the `Build` workflow now completes with `SUCCESS`. That confirms it was indeed just the known flake, not a regression introduced here, so my approval is now unconditional. One thing still keeping `reviewDecision` at `REVIEW_REQUIRED`: @SEZ9's CHANGES_REQUESTED review was submitted against an earlier commit (a396320c). As I noted in my latest review, the current head already addresses that feedback. @SEZ9, whenever you get a chance, a re-review/dismissal on the current head would help move this toward merge - otherwise this just needs a maintainer with write access to give the formal sign-off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
