DanielLeens commented on PR #11897: URL: https://github.com/apache/seatunnel/pull/11897#issuecomment-5409131913
Following up here since this comment is directly relevant to where things stand. **Head unchanged.** I re-checked: the current head (`721f9a0779330fad704f68b76ba3e141e4de4e06`) is the exact commit I already reviewed on 2026-08-22, so there's nothing new on my side to re-verify — my "ready to merge" from that round still stands. **What's actually blocking merge right now is procedural, not technical.** `mergeStateStatus` is `blocked` because @goutamadwant's 2026-08-20 `CHANGES_REQUESTED` review is still outstanding on GitHub even though all three points it raised (path-filter glob, `after_restore.sh`/endless-scenario verification wording, `Closes #11356` → `Part of #11356`) were fixed and I independently confirmed the fixes on 2026-08-22. This PR needs @goutamadwant (or another maintainer) to actually re-review and clear that status — your ping above is the right next step, not something I can resolve from a review comment. **Sanity-checked the design doc against current `dev` while I was here** (this branch is ~52 commits behind): `tools/upgrade_compatibility/` still exists on `dev` with the same `run_upgrade_compatibility.sh` and the same two scenarios (`generic-fake-localfile`, `mysql-cdc-multitable-localfile`) the doc describes, and `seatunnel-connectors-v2/connector-cdc/` still contains only per-database subdirectories (two new ones, `connector-cdc-db2` and `connector-cdc-vitess`, have been added since, but the doc's `connector-cdc/**` glob already covers those without needing an update). One thing worth flagging: the doc's "Endless scenario verification" section documents `after_restore.sh` as a required hook, but that hook doesn't exist yet in the real `run_upgrade_compatibility.sh` on `dev` — however the doc itself is honest about this, listing "Add `after_restore.sh` hooks to all endless scenarios" as an open, unchecked action item in its own roadmap section, so there's no factual mismatch between the doc and the current implementation state. **On CI:** the Apache-side `Build` check shows `fail`, but that's a stale pointer — the actual runs on the fork (`zhang-arvin/seatunnel`) both show `cancelled`, not a genuine failure, which is consistent with this being a docs-only change (no `.java`/workflow files touched) hitting a CI infra/queue issue rather than anything introduced by this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
