SEZ9 commented on PR #11029: URL: https://github.com/apache/seatunnel/pull/11029#issuecomment-5409366423
Thanks for the thorough verification, @DanielLeens — that's exactly the confirmation I was hoping for. On Issue 1: your merge-base diff matches my read. Since `SNAPSHOT_ONLY` is handled entirely by the shared incremental framework and not by anything Postgres-dialect-specific, my preference is to simply add it back to `OpengaussSourceOptions.STARTUP_MODE` rather than document it away — dropping a working mode with no replacement isn't something we should ship, and restoring it also resolves the compat break cleanly. Agreed this remains a blocker, and agreed your earlier approval is superseded until it's addressed. On Issue 3: agreed on both the diagnosis and the severity. It's safe today only by accident (stateless static constant), so hardening via a constructor argument or a `requireNonNull` plus a Javadoc warning on the hook is the right shape — non-blocking, but worth doing while this code is being touched. To be clear on status: nothing has changed on head `075001b0b5a9`, so all points from my review remain open. Concrete asks for the next push: 1. **Blocking:** restore `SNAPSHOT_ONLY` in the OpenGauss `startup.mode` choice set (Issue 1), and update the en/zh Opengauss-CDC docs to state the valid values (Issue 6). 2. Add an actionable error message and an explicit upgrade note for the restored `require-replica-identity-full` enforcement (Issues 2 and 5). 3. Confirm or address the serialized-DAG compatibility question around the new `PgBaseIncrementalSource` hierarchy (Issue 4). 4. Minor: fix the raw `(SingleChoiceOption)` cast (Issue 7) and the "Apache OpenGauss" Javadoc wording (Issue 8). Happy to re-review together with you once a new revision is pushed. <!-- streview-comment:530 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
