zhang-arvin commented on PR #11844: URL: https://github.com/apache/seatunnel/pull/11844#issuecomment-5412807245
@DanielLeens Thanks for the thorough review and the independent verification of the checkpoint-restore fix — really appreciate the diligence. I've addressed all three recommendations: 1. **Unit test**: Added `IncrementalSourceCheckpointCapturedTablesTest` with 7 test cases covering empty state, single source, full union, and deduplication — verifying the table-drift-on-restore scenario is pinned down. 2. **E2E test**: Added `MysqlCDCSnapshotOnlyIT` with a basic snapshot-only happy-path test (BATCH mode, `startup.mode = snapshot-only`). 3. **Javadoc**: Added documentation on `getCheckpointCapturedTables()` explaining why checkpoint-derived tables are needed (not live discovery) and the 4 data sources used for the union. Please take another look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
