SEZ9 commented on PR #11423: URL: https://github.com/apache/seatunnel/pull/11423#issuecomment-5421602890
Thanks @DanielLeens — agreed on your restatement, and to answer directly: the follow-up commit is not done yet. The head is still `b7b7288ad234`, so nothing beyond what you approved on August 4 has been pushed. Here is my plan for that single follow-up commit, matching your four MEDIUM items: 1. Add the `AWS_CONTAINER_CREDENTIALS_RELATIVE_URI` prerequisite to the ECS `ContainerCredentialsProvider` example (and broaden the troubleshooting paragraph beyond `ClassNotFoundException`). 2. Rewrite the contrast to describe the checkpoint pass-through behavior directly and link to the S3File docs rather than inlining that page's validation behavior. 3. Anchor the IRSA/SDK claims explicitly to the pinned `aws-java-sdk-bundle:1.11.271` so a future SDK bump makes the version boundary visible instead of silently stale. 4. Add the IMDS blast-radius note for EKS node-role credentials so readers understand every pod on the node can read those credentials. I'll fold 5–7 into the same commit: a short note explaining the mixed credential-provider namespaces across examples, removing the double blank line after the instance-profile code fence, and applying everything to both `docs/en/engines/zeta/checkpoint-storage.md` and `docs/zh/engines/zeta/checkpoint-storage.md` at structurally equivalent insertion points, per the PR's stated goal of keeping the two in sync. Two small asks from my side: - Since you've indicated the commit should ideally land before merge, please hold off merging until I push it — I'd rather not ship the guidance without the ECS prerequisite and the IMDS note. - Once it's up, a quick sanity check from you that the EN/ZH insertion points look structurally equivalent (your point on 5–7) would be appreciated, since that alignment was part of the original review. I'll comment here when the commit is pushed. Thanks for the thorough follow-through on the severity correction. <!-- streview-comment:565 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
