SEZ9 commented on PR #11559: URL: https://github.com/apache/seatunnel/pull/11559#issuecomment-5421604850
@DanielLeens Thanks for the round 14 pass — and no apology needed; catching the shaded-parser behavior after re-deriving from a blank page is exactly why that discipline is worth it. Answering your points directly: 1. **Shaded HOCON path separator** — confirmed on my side. Since SeaTunnel's shaded HOCON parser uses `->` rather than `.` as the path separator, the dotted strings in the new validator (`schema-change.behavior`, `state.backend`, `join.type`, …) are indeed resolved as single literal keys, which explains every `expected true, was false` failure in `MultipleTableJobConfigParserTest` at `76611dfa15`, and why round 13's hypothesis of a test-construction quirk didn't hold. This is **not fixed yet**. My plan: rework the validator to resolve nested keys through the shaded parser's separator, and add a test that goes through the real shaded parser (not a hand-built config object) so this class of bug can't pass silently again. I'll push that as the next commit. 2. **`kafka-connector-it (8, ubuntu-latest)`** — you mention you diagnosed this failure "below", but your comment body appears truncated before that section. Could you re-post the diagnosis? I'd like to fold that fix into the same commit rather than churn CI twice against run `32582665583`'s baseline. 3. **Carryover from the earlier finding** — the unsafe Java deserialization pattern flagged in `seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceReader.java` is still open on my side. I'll address it in the same push, and I'd appreciate you re-checking that spot specifically in your next round. Concrete asks: (a) the un-truncated `kafka-connector-it` diagnosis, and (b) a re-verify of the `KafkaSourceReader` deserialization fix once the new commit lands. Everything else is on me — expect a commit addressing points 1 and 3 shortly. <!-- streview-comment:572 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
