DanielLeens commented on PR #11972: URL: https://github.com/apache/seatunnel/pull/11972#issuecomment-5433240670
Thanks for the note on enabling CI, @davidzollo -- that's helpful for @Linz1248 to get the automated checks running. Just to keep things clear: once Build is green, the review conclusion above still stands independently of CI -- the blank-value regression (Issue 1) needs to be addressed before merge. The removed `isNotBlank` guards on `client.service-url`, `admin.service-url`, and single-table `subscription.name` aren't actually covered by `OptionRule.required()`, since that rule only checks non-null presence, not blank/whitespace content. Happy to take another look as soon as that's in, along with the corresponding blank-string test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
