DanielLeens commented on PR #11012: URL: https://github.com/apache/seatunnel/pull/11012#issuecomment-5433244347
Hi @lazyfetch @davidzollo, I just rechecked the fork's CI run for the current head (`bca8da5`, unchanged since July 30). The picture matches exactly what you described: `updated-modules-integration-test-part-4` (the shard that runs `JdbcSybaseIT`) never completes -- both matrix jobs sit for roughly 3 hours and then get force-cancelled, which lines up with the `nguoianphu/docker-sybase` image hanging/crashing on startup in the current runner environment rather than any regression in the dialect/mapper/row-converter code. So from Daniel's side there is still no new source-level blocker on this head; this is the same fact I reported on August 3, not a new one. On your question: I don't think an `AbstractMethodError` workaround or a new try/catch in `SimpleJdbcConnectionProvider` belongs in this PR's scope -- that is exactly the "stepping outside the scope of a source-connector PR" concern you raised yourself, and it would touch a shared connection-provider path used by every JDBC connector, not just Sybase. Between the two options you listed, temporarily disabling/skipping `JdbcSybaseIT` (with a comment linking back to this thread and the known `docker-sybase` image issue) is the lower-risk path from a review standpoint, since it unblocks the CI gate without touching any already-reviewed source code. Trying an alternative Sybase test image is also worth a shot if you know of one, but I can't vouch for a specific replacement's fidelity to real Sybase behavior. That said, I only have read-only review permissions here, so whether it's acceptable to merge with `JdbcSybaseIT` disabled (versus requiring a working container before merge) is a maintainer-level call, not something I can sign off on alone. @davidzollo, could you weigh in on which of those two paths you would prefer, since you have merge authority here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
