yzeng1618 commented on PR #11971: URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-5433590676
Addressed the review findings in commit 281fe76d1: - Validate every result column's catalog/schema/table before merging underlying-table metadata. Detected joins, inconsistent origins, and missing origin metadata now keep the query-derived table unchanged. - Apply the guard to both catalog-backed and direct JDBC fallback paths, including the Statement-based metadata paths used by OceanBase and YashanDB. - Add the requested UnderlyingTableLoader Javadoc and link the EN/ZH documentation to the existing query primary-key caution. - Add regression coverage for same-table metadata, a multi-table JOIN result, and skipping the metadata loader for multi-table queries. Validation: - .\mvnw.cmd -o spotless:apply - .\mvnw.cmd -o -pl seatunnel-connectors-v2/connector-jdbc -Dskip.spotless=true -Dcheckstyle.skip=true -Dtest=CatalogUtilsTest,JdbcCatalogUtilsTest test (32 tests, 0 failures, 0 errors) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
