DanielLeens commented on PR #11986: URL: https://github.com/apache/seatunnel/pull/11986#issuecomment-5437743729
Quick correction on my own review above: I submitted it as "Request changes," but that doesn't match my actual conclusion. To restate clearly — **there are no blocking issues in this PR**. Both items I listed (the undocumented record-pool/capacity invariant, and the test-name nit) are Medium/Low, non-blocking suggestions, and my "Issue Summary" and "Blockers — must be fixed: None" already say so explicitly. GitHub doesn't let me change a submitted review's state after the fact, only its body, so the sidebar will keep showing "Changes requested" even though my technical conclusion is "ready to merge after (optional) fixes." A maintainer with write access can dismiss/override that state; from my side, there is nothing you need to resolve before this can be merged. Sorry for the confusing signal, and thanks again for the clean, production-faithful benchmark harness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
