DanielLeens commented on issue #11973: URL: https://github.com/apache/seatunnel/issues/11973#issuecomment-5438933393
Thanks for the detailed downstream verification, and thanks again to @waterWang and @zhangshenghang for the quick follow-up PRs. I rechecked the current `apache/dev` head (`e6caf5a4b337`). The issue is still grounded there: `AbstractJdbcSourceChunkSplitter.getSplitColumn()` first validates an explicit `snapshotSplitColumn` only against `dialect.getUniqueKeys()`, and only later falls back to primary-key / unique-key discovery for automatic split-column selection. That means an explicitly configured physical primary key can still be rejected before the automatic fallback path is reached. Your August 27, 2026 verification result is useful because it shows the intended behavior directly: - the configured physical primary key was accepted; - the previous `Config snapshotSplitColumn not unique key` path disappeared; - the generated snapshot splits used the configured primary-key boundaries. At this point, the strongest current repair signal is #11979: it has your downstream validation and its current Build is green. #11977 is still open but its current Build is failing. Please keep the fix path converged on one implementation and one focused regression test, rather than landing two near-duplicate repairs. For review, the contract should stay narrow: 1. accept an explicitly configured split column when it belongs to the physical primary key or a unique key; 2. preserve the existing automatic fallback behavior when the config is absent or invalid; 3. keep the regression coverage focused on this exact configured-primary-key path. Unless the same scenario still reproduces on current `dev` with the #11979 logic, the next maintainer action belongs on PR review rather than more issue-thread debugging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
