DanielLeens commented on PR #11974: URL: https://github.com/apache/seatunnel/pull/11974#issuecomment-5480366459
Thanks @surafel58 — agreed on Issue 5. Deferring `Retry-After` handling to a follow-up is the right call: it needs `HttpResponse`/`HttpClientProvider` in `connector-http-base` to carry response headers first, which is a shared-module change that shouldn't ride along with this fix. Please link the follow-up issue here once it's filed so it's easy to track from this thread. From my side there's nothing further blocking: both review rounds' findings are verified fixed at `7e01c3b1`, and I just re-confirmed live that CI (`Build`, `Notify test workflow`, `labeler`) is green on that same head SHA. As a comment-only reviewer I can't set the formal approval, so this is now waiting on a committer with write access to approve and merge — cc @davidzollo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
