DanielLeens commented on PR #11829: URL: https://github.com/apache/seatunnel/pull/11829#issuecomment-5492469132
Good question, and yes — the guidance you're referring to on #11734 is real and applies here too. For context on exactly what was said there: on 2026-08-23, @davidzollo (who has merge/write access on this repo) commented on #11734: > The STIP proposal should be presented in an issue or issue comments (or on the [email protected] mailing list), rather than drafting design proposals separately via PRs. I deferred to that on #11734 the next day, and since this PR is the same pattern (a design-only doc for GH-11355 / STIP-36, already canonical in #11790), I think the same convention should apply here. To be clear about the substance versus the process, though: my technical review of this PR's content is unchanged and still positive — I re-verified every class/file citation against current `dev` and everything checks out, and the placement fix you made after my earlier feedback (moving the doc out of `introduction/configuration/` and dropping the link from the live `schema-evolution.md` page) was exactly right. None of that work is wasted; it's a question of where the discussion should live going forward, not whether the design itself holds up. So: moving the remaining discussion to #11790 (or the dev@ list) and closing this PR sounds like the right move to me, consistent with what davidzollo asked for on #11734. That said, I'm a comment-only reviewer here without merge/write access, so I can't make that call binding on my own — it'd be good to get an explicit nod from davidzollo (or another maintainer) on this thread before you close it, just so there's a clear record that the same convention was applied intentionally rather than assumed. Happy to carry over my review notes to #11790 if that's useful once the discussion moves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
