DanielLeens commented on PR #12026: URL: https://github.com/apache/seatunnel/pull/12026#issuecomment-5492863813
Thanks @davidzollo — agreed, and confirming what the screenshot shows: this branch currently has merge conflicts against `dev` (`mergeStateStatus: DIRTY`, `mergeable: CONFLICTING`). On the code-review side, this doesn't change anything: my full review of this exact head (`e52fb22c`) found no correctness or compatibility blockers and reached a `Ready to merge` conclusion — the only thing standing between this PR and merge is the conflict itself. @nzw921rx could you please rebase onto the latest `dev` and resolve the conflicts? Once that's done and CI reruns clean, this should be good to go from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
