DanielLeens commented on PR #11028:
URL: https://github.com/apache/seatunnel/pull/11028#issuecomment-5518363447
Confirming what's already visible above: I re-reviewed `301cce1ede52` from
scratch that same morning (not just the delta since my previous
`CHANGES_REQUESTED`), including the registration chain, the runtime path,
tests, and docs, and approved it — every item from both my earlier rounds and
@SEZ9's Aug 25 pass is either genuinely fixed in the source (pagination now
fails fast via `rejectUnsupportedPagination()` instead of silently truncating,
`getSourceClass()`, the `${SHOPIFY_ACCESS_TOKEN}` example, the E2E gap) or
correctly routed to #12025 for the two `connector-http-base`-wide concerns
(scheme validation, `@Data` `toString()` token exposure) that aren't
Shopify-specific. No blockers on my side.
I also checked the merge gate again just now: `mergeStateStatus` is
`BLOCKED` with `mergeable: MERGEABLE` and `reviewDecision: REVIEW_REQUIRED` —
that's a review-count requirement from branch protection, not a live
`CHANGES_REQUESTED` or a conflict. So the practical next step is what you
asked: @SEZ9, since your Aug 25 review predates the fixes above, could you take
another pass and update your review state on the current head? That should be
enough to clear this one.
Thanks again for the persistence through all the rounds here,
@GabrielBBaldez.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
