This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new 2e2e9b8040 [Improve][Connector-V2] Use isEmpty() instead of size() > 0
in ES connectors (#11996)
2e2e9b8040 is described below
commit 2e2e9b804004f7a57da4a84219ed2438232b26fc
Author: corgy-w <[email protected]>
AuthorDate: Thu Sep 3 07:52:06 2026 +0000
[Improve][Connector-V2] Use isEmpty() instead of size() > 0 in ES
connectors (#11996)
---
.../seatunnel/easysearch/serialize/index/IndexSerializerFactory.java | 2 +-
.../connectors/seatunnel/easysearch/sink/EasysearchSinkWriter.java | 2 +-
.../connectors/seatunnel/easysearch/source/EasysearchSourceReader.java | 2 +-
.../seatunnel/elasticsearch/serialize/index/IndexSerializerFactory.java | 2 +-
.../seatunnel/elasticsearch/sink/ElasticsearchSinkWriter.java | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git
a/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/serialize/index/IndexSerializerFactory.java
b/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/serialize/index/IndexSerializerFactory.java
index ba3eeb0cf4..3eec07620f 100644
---
a/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/serialize/index/IndexSerializerFactory.java
+++
b/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/serialize/index/IndexSerializerFactory.java
@@ -29,7 +29,7 @@ public class IndexSerializerFactory {
public static IndexSerializer getIndexSerializer(
String index, SeaTunnelRowType seaTunnelRowType) {
List<String> fieldNames = RegexUtils.extractDatas(index,
"\\$\\{(.*?)\\}");
- if (fieldNames != null && fieldNames.size() > 0) {
+ if (fieldNames != null && !fieldNames.isEmpty()) {
return new VariableIndexSerializer(seaTunnelRowType, index,
fieldNames);
} else {
return new FixedValueIndexSerializer(index);
diff --git
a/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/sink/EasysearchSinkWriter.java
b/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/sink/EasysearchSinkWriter.java
index 6b42e2f526..8f2fe038b1 100644
---
a/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/sink/EasysearchSinkWriter.java
+++
b/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/sink/EasysearchSinkWriter.java
@@ -104,7 +104,7 @@ public class EasysearchSinkWriter
try {
RetryUtils.retryWithException(
() -> {
- if (requestEzsList.size() > 0) {
+ if (!requestEzsList.isEmpty()) {
String requestBody = String.join("\n",
requestEzsList) + "\n";
BulkResponse bulkResponse =
ezsClient.bulk(requestBody);
if (bulkResponse.isErrors()) {
diff --git
a/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/source/EasysearchSourceReader.java
b/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/source/EasysearchSourceReader.java
index 29c8cfda7f..63098abe71 100644
---
a/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/source/EasysearchSourceReader.java
+++
b/seatunnel-connectors-v2/connector-easysearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/easysearch/source/EasysearchSourceReader.java
@@ -85,7 +85,7 @@ public class EasysearchSourceReader implements
SourceReader<SeaTunnelRow, Easyse
sourceIndexInfo.getScrollSize());
scrollId = scrollResult.getScrollId();
outputFromScrollResult(scrollResult,
sourceIndexInfo.getSource(), output);
- while (scrollResult.getDocs() != null &&
scrollResult.getDocs().size() > 0) {
+ while (scrollResult.getDocs() != null &&
!scrollResult.getDocs().isEmpty()) {
scrollResult =
ezsClient.searchWithScrollId(
scrollResult.getScrollId(),
diff --git
a/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/index/IndexSerializerFactory.java
b/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/index/IndexSerializerFactory.java
index 69bb6d7358..be00623085 100644
---
a/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/index/IndexSerializerFactory.java
+++
b/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/index/IndexSerializerFactory.java
@@ -29,7 +29,7 @@ public class IndexSerializerFactory {
public static IndexSerializer getIndexSerializer(
String index, SeaTunnelRowType seaTunnelRowType) {
List<String> fieldNames = RegexUtils.extractDatas(index,
"\\$\\{(.*?)\\}");
- if (fieldNames != null && fieldNames.size() > 0) {
+ if (fieldNames != null && !fieldNames.isEmpty()) {
return new VariableIndexSerializer(seaTunnelRowType, index,
fieldNames);
} else {
return new FixedValueIndexSerializer(index);
diff --git
a/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/sink/ElasticsearchSinkWriter.java
b/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/sink/ElasticsearchSinkWriter.java
index 13b80ff3f5..4a45538ee7 100644
---
a/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/sink/ElasticsearchSinkWriter.java
+++
b/seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/sink/ElasticsearchSinkWriter.java
@@ -243,7 +243,7 @@ public class ElasticsearchSinkWriter
try {
RetryUtils.retryWithException(
() -> {
- if (requestEsList.size() > 0) {
+ if (!requestEsList.isEmpty()) {
String requestBody = String.join("\n",
requestEsList) + "\n";
BulkResponse bulkResponse =
esRestClient.bulk(requestBody);
if (bulkResponse.isErrors()) {
