DanielLeens commented on PR #11836: URL: https://github.com/apache/seatunnel/pull/11836#issuecomment-5537865684
Thanks for following up so quickly, @FenjuFu — I checked the run directly rather than taking the summary at face value: https://github.com/FenjuFu/seatunnel/actions/runs/31995335393 is a real `workflow_dispatch` run on your fork against this exact head (`104998e16`), the `build` job (buildx bake across the `linux/amd64` + `linux/arm64` matrix, including the `SPARK_SHA512` checksum verification step) completed successfully, and `publish` correctly stayed `skipped` since there are no push credentials on the fork. That's exactly option 2 from my last comment, and it closes the CI-verification gap I flagged. So to summarize where this leaves things: the new `pull_request:` trigger still can't validate itself inside this PR's own run (that's an inherent GitHub limitation for workflow-file changes from fork PRs, not something fixable in this branch), but the actual multi-arch build logic it's meant to protect has now been exercised by a real, successful manual run on this head. I don't have any remaining concern here. ### Conclusion: Ready to merge No blockers from my side. Thanks both for the careful back-and-forth on this — dismissing my earlier approval to get a real CI signal instead of assuming coverage was exactly the right call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
