davidzollo commented on code in PR #10447:
URL: https://github.com/apache/seatunnel/pull/10447#discussion_r3940869380
##########
docs/en/connectors/source/Github.md:
##########
@@ -276,7 +276,7 @@ Source plugin common parameters, please refer to [Source
Common Options](../comm
## Example
```hocon
-Github {
+Hubspot {
url = "https://api.github.com/orgs/apache/repos";
access_token = "xxxx"
method = "GET"
Review Comment:
Re-checked this in the latest full review pass: the shared
`HttpSourceFactory.getHttpBuilder()` refactor that introduced
`getHttpOptionBuilder()` is strictly additive — it only formally exposes six
options (binary_chunk_size, enable_multi_lines, connect_timeout_ms,
socket_timeout_ms, keep_params_as_form, keep_page_param_as_http_param) that
Github/Gitlab/Klaviyo and the other 8 existing HTTP wrapper connectors already
inherited and could already use; no option was renamed, removed, or had its
default changed. So Github.md's documented contract stays accurate and doesn't
need an update for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
