yigitcan-ozturk opened a new pull request, #12148:
URL: https://github.com/apache/seatunnel/pull/12148
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
Related to #11007.
This PR implements the accepted connector-sentry declarative validation
slice.
### What changed
- Keep `dsn` required and add `Conditions.notBlank(SentrySinkOptions.DSN)`.
- Add focused factory-validation coverage for:
- a valid nonblank DSN;
- an empty DSN;
- a whitespace-only DSN.
- Preserve all existing option names and nonblank configurations.
- Leave `SentrySinkWriter`, `SentryOptions`, network behavior, and remote
validation unchanged.
### Does this PR introduce _any_ user-facing change?
Yes.
Invalid empty or whitespace-only `dsn` values are now rejected during
connector option validation instead of reaching Sentry runtime initialization.
Existing nonblank configurations are unchanged.
### How was this patch tested?
Focused unit tests were added in `SentryFactoryTest` to cover:
- valid DSN;
- empty DSN;
- whitespace-only DSN.
Repository CI will run the connector test suite for this PR.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties and add
new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/)
5. Update connector
https://github.com/apache/seatunnel/blob/dev/config/plugin_config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
