CryoThrust commented on PR #12101: URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-5568899849
Follow-up on F2-F8 for the current head (885428e53):\n\n- F2: done in 885428e53. The JSON result is serialized through Jackson ObjectNode/ObjectMapper; the regression test covers quotes, newlines, tabs, and backslashes in an error message.\n- F3: done in the existing implementation. A null exception message falls back to Validation failed before the value is used for both the result and the thrown ConfigCheckException.\n- F4: the machine-readable result is emitted with System.out.println on the JSON path. Validation errors are represented by the JSON result; unrelated plugin/library output is outside this command's control. No additional text-mode logging is added by this change.\n- F5: unchanged behavior; FileUtils.getConfigPath() remains covered by the existing exception path and text-mode behavior.\n- F6: unchanged existing success path; successful JSON emission is not converted into a validation failure by the catch block.\n- F7: done in 885428e53. Both English and Chinese use r-command.md now document schemaVersion, valid, phase, errors, error fields, and sanitization.\n- F8: done in 885428e53. The mixed &&/|| condition is explicitly parenthesized.\n\nVerification: ConfigValidationResultTest passes with the public-central Maven settings; Spotless was also run for the touched module. No new PR was opened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
