DanielLeens commented on PR #12049: URL: https://github.com/apache/seatunnel/pull/12049#issuecomment-5577181412
Thanks for confirming — agreed on both counts, and it's a useful note to have on record for anyone else digging into the Cosmos DB emulator flakiness independently: `AbstractAzureCosmosDBIT.readRows` builds the reader and its split directly and never goes through the enumerator, so `getSplitOwner` was never on that stack trace's path even in principle. Re-verified live rather than relying on the snapshot: `Build` is green on `635d7874` (current head, unchanged since my last review), but `mergeStateStatus` is `BLOCKED` with `reviewDecision: REVIEW_REQUIRED`. My review here is comment-level rather than write-level, so it doesn't satisfy branch protection on its own even though the review I submitted is an approval. The code-side conclusion stands unchanged: this is a one-line delegation to the shared `HashUtils.bucketIndex` helper (same migration as #11937/#11987), behavior-identical to the inline formula it replaces, with correct regression tests covering the previously-untested non-zero split-id and `Integer.MIN_VALUE` cases. No blockers from me. @davidzollo — flagging this for a merge-capable approval/merge whenever you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
