DanielLeens commented on PR #12153:
URL: https://github.com/apache/seatunnel/pull/12153#issuecomment-5577184556

   +1 to @davidzollo's note here — it matches what I found when I dug into this 
myself earlier (zero Actions runs on the `zhangsean/seatunnel` fork), so this 
is Actions needing to be enabled on the fork, not a hidden test failure.
   
   @zhangsean once Actions are enabled, there's one more thing needed before 
the `Build` check will actually pass end to end: please run `./mvnw 
spotless:apply -pl seatunnel-connectors-v2/connector-jdbc -am -nsu` locally and 
push the reformatted diff (see Issue 1 in my review above) — right now the diff 
carries a lot of unrelated line-ending changes that will fail the format-check 
step on their own, independent of whether the functional tests pass. The core 
logic fix (FULLTEXT/SPATIAL index handling in `MySqlCatalog` / 
`MysqlCreateTableSqlBuilder`) looks correct and well-tested as-is.
   
   No action needed from me right now — happy to take another look as soon as a 
new commit lands with CI actually running.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to