Rangsh commented on PR #12172: URL: https://github.com/apache/seatunnel/pull/12172#issuecomment-5577617167
@DanielLeens Thanks for the thorough review — really helpful. I addressed the follow-ups in https://github.com/Rangsh/seatunnel/commit/c1dc10d9d: 1. **Issue 1 (Medium)**: added coverage for the `debeziumEnabledSchema=true` streaming path - `testSerializationAndSchemaIncludeDeserialization` wraps the existing schema-less fixture into `{"schema":...,"payload":...}` envelopes and asserts end-to-end parse - `testDeserializeSchemaIncludedMissingPayload` asserts the missing-`payload` error path 2. **Issues 2–4 (Low)**: - documented why `resolveTableId` keeps the identity fast-path + fallback - added short Javadoc for `applyRowMeta` / `fillSource` - moved `getProducedType()` back above the private helpers Local verification: `DebeziumJsonSerDeSchemaTest` + `DebeziumJsonDeserializationSchemaDispatcherTest` are green (15 tests). On the CI point: agreed the failing IT jobs look unrelated to this Format change. I’ll sync with latest `dev` and re-check the failed jobs next unless you prefer that as a separate follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
