DanielLeens commented on issue #12063: URL: https://github.com/apache/seatunnel/issues/12063#issuecomment-5584885215
Thanks for supplying the controlled local comparison. It is useful interim evidence that the fixture can affect the measured path, but it is not a production-speedup result and it does not yet substitute for a same-runner baseline/head comparison with attached raw JMH/GC data. I also checked the current #12173 diff. It combines benchmark-fixture changes with a production `JobHistoryService.storeFinishedPipelineMetrics` read/merge/put rewrite. Those are different responsibilities and cannot be accepted as one benchmark-calibration PR: the production rewrite needs its own concurrency, durability, and caller-contract evidence, while the fixture correction must stand on its own. Please split the fixture-only change from the production behavior change, attach the before/after raw JMH JSON and per-fork GC or wall-clock data, and avoid claiming that the remaining variance is resolved. The linked PR is still blocked with a failed Build, so no implementation conclusion can be made yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
