nzw921rx commented on PR #12263: URL: https://github.com/apache/seatunnel/pull/12263#issuecomment-5629595315
Addressed the review feedback in c1ea42845b: - Added lifecycle documentation for the Flink and Spark adapters, including the single-task-thread assumption, idempotent cleanup, and Spark's register-listener-before-open ordering. - Avoided calling `TaskContext.get()` for every Spark row by moving it behind the first-use guard. - Documented why the open flags use task-thread booleans while close uses an atomic guard. I also inspected all failures from the previous Build run: - The two transform-v2 jobs failed only for Python Transform on Flink 1.13.6. The legacy image's Debian Bullseye security metadata was expired, so `apt-get update` failed and `python3` was unavailable. Python Transform E2E is now disabled only for `FLINK_1_13`; the other runtime variants remain enabled. - engine-k8s failed while downloading k3s because of a self-signed TLS certificate. - engine-v2 JDK 8/11 failed in unrelated checkpoint/failover timing assertions. - RocketMQ failed an unrelated restore-count assertion (expected 45, actual 55) on the Zeta container. Local validation completed successfully: - Flink lifecycle tests: 3 passed - Spark lifecycle tests: 3 passed - Python Transform E2E test sources: compiled - Flink 1.13/1.15/1.20 and Spark 2.4/3.3 starter packages: built successfully - Spotless applied -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
