SEZ9 commented on issue #12164: URL: https://github.com/apache/seatunnel/issues/12164#issuecomment-5642785396
Thanks @Rangsh — acknowledged. Noted that the both-sides regression coverage landed on #12218 in `fee6db3b3`, and that the four review asks from the PR description checklist (rollback boundary, deterministic post-publication failure injection with a real second `deployTask` of the same `TaskGroupLocation`, master-failover skip preservation for an already active healthy task, and scope kept to current `dev`) are what that follow-up is meant to close out. Agreed that the remaining discussion stays on the PR. Nothing further is needed from you on this issue thread; I'll review `fee6db3b3` on #12218 against those four points and leave any comments there. One small ask when you get a chance: on the PR, please point to which test(s) cover the "both sides" of the boundary (the callback side and the submission side) so the reviewers can map the coverage to the checklist quickly. <!-- streview-comment:974 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
