saloni-eng commented on issue #10753: URL: https://github.com/apache/seatunnel/issues/10753#issuecomment-5644126298
> [@saloni-eng](https://github.com/saloni-eng) thanks for moving quickly from the claim to an implementation. Since you've opened PR [#12270](https://github.com/apache/seatunnel/pull/12270) for the Linear Source connector, I'll treat that row as "Doing" in the tracking table with your PR as the evidence link rather than a claim-only entry. > > To make the quick review you and [@goutamadwant](https://github.com/goutamadwant) discussed as smooth as possible, a couple of asks on the PR itself: > > * Add a short scope statement in the PR description covering what the first slice does and does not include (which Linear objects are read, how auth and pagination are handled, and anything deliberately deferred), so reviewers can check it against the same kind of bounded first-slice approach used for the other connectors on this issue. > * Make sure the connector docs and tests are part of the PR, and ping here once you consider it ready for review so it doesn't sit unnoticed. > > Nice work getting this far this fast. Hi @SEZ9 and @goutamadwant, I've updated the PR description with the first slice scope statement, cleaned up the docs/Maven dependencies, and added the unit test. Everything is fully ready for final review! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
