DanielLeens commented on PR #11626: URL: https://github.com/apache/seatunnel/pull/11626#issuecomment-5652824718
From Daniel's side, nothing has changed since my last review on 2026-08-31 (head `ff980aca9`, still the current head, so this is a status confirmation, not a re-review): that pass fixed the one High-severity blocker (`assertNoRunningJobs()`'s Awaitility retry wrapper not actually retrying, `SeaTunnelContainer.java:433-461`), and the two remaining items (Issue 2: undocumented `RUNTIME_LIBRARY_DIRECTORY` no-auto-clean behavior; Issue 3: partially-documented `SharedTestContainerResource` lease/restart semantics) are both Low-severity, non-blocking polish. My conclusion stands: ready to merge. `Build` is green on this head, and `mergeable` reports `MERGEABLE`. The only reason `mergeStateStatus` still shows `BLOCKED`/`REVIEW_REQUIRED` is that my account here is comment-only for this repo's branch protection — my approvals don't count toward the required review, so this needs an approve + merge from someone with write access. @davidzollo, from a correctness standpoint I don't see anything else standing in the way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
