SEZ9 commented on PR #12300: URL: https://github.com/apache/seatunnel/pull/12300#issuecomment-5674519647
Thanks @utafrali and @DanielLeens — the unpinned `ruff` was the only substantive item across both reviews, and it is fixed in `f9e232ed8`. I took both halves of the suggested remedy, so that the pin has a single visible meaning in both places a contributor might look: - `.github/workflows/cli.yml` — `python -m pip install --upgrade ruff` → `python -m pip install 'ruff==0.16.7'` - `seatunnel-cli/pyproject.toml` — the `dev` extra now carries `ruff==0.16.7` instead of a bare `ruff`, so `pip install -e '.[dev]'` resolves exactly what the Lint job runs Each site has a short comment pointing at the other, so a future bump is an obvious two-line edit rather than a silent drift. Verified locally rather than assumed: I installed `ruff==0.16.7` and ran `ruff check .` from `seatunnel-cli/` against the current head with the `[tool.ruff.lint] select` from this PR — `All checks passed!`, exit 0. So the pinned version is not merely pinned, it is the version the gate is known-green on. On @DanielLeens' reasoning in Issue 1: agreed the blast radius of the currently-selected codes is small, and the local/CI-drift half of the concern is really the more valuable one to close, since that is what a contributor experiences directly. The pin closes both. Still tracked for the follow-up clean-up PR promised in the description (18 existing `ruff` findings outside the current `select`, `black`-formatting `seatunnel-cli/`, and widening `[tool.ruff.lint] select` to match): pinning `black` belongs in that change rather than this one, since the formatting output is version-dependent and the pin is only meaningful once the tree is actually formatted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
