SEZ9 commented on issue #12304: URL: https://github.com/apache/seatunnel/issues/12304#issuecomment-5691916457
Thanks for the detailed report and reproduction. The two defects match what you describe: `getArrayMapNotNullSize` dereferences null map elements, and `getBytesForArray` has no `ROW` branch, so schema-aware row arrays contribute zero and that incomplete cached size is then reused. Skipping null map-array elements and including `ROW` in the existing recursive, schema-aware array calculation is the right narrow fix. Since #12305 covers this, let's continue the discussion in the PR review and keep this issue open until it is merged. One question for the PR: could you confirm which expected byte totals the new regression tests assert, and whether the typed and untyped call orders are both checked for the same result after the fix? <!-- streview-comment:1090 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
