CryoThrust commented on PR #12149: URL: https://github.com/apache/seatunnel/pull/12149#issuecomment-5693827088
@DanielLeens thanks for breaking those lanes down — that was more precise than my own summary, and it is what I acted on. Synced as you suggested. `b70026e63` is now rebased onto `b37af3a9b` (`dev`), a fast-forward with no conflicts (the diff is unchanged: `CheckpointCoordinator.java` + its test). The branch had drifted to 18 commits behind by the time I did it, so `all-connectors-it-7`/S3 should now pick up `0d9f9e2303d`. Rebuilt and ran the affected area on the synced head: ``` CheckpointCoordinatorTest 17 run, 0 failures ``` (17 rather than 16 because `dev` picked up an extra test in that class since my last run.) The two non-blocking items from your earlier review are unchanged and still outstanding by design: the `NOT_STARTED_STATUSES` Javadoc nit is in, and the pre-existing check-then-act race is deliberately not folded in here — it is tracked as #12342 so it does not get lost. I'll ping you once the synced head's CI settles, per your last line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
