SEZ9 commented on issue #10753: URL: https://github.com/apache/seatunnel/issues/10753#issuecomment-5738841492
Thanks @goutamadwant for opening #12282 (PayPal Transaction Search source) and #12283 (TikTok Ads source). I'll treat both rows as "Doing" in the tracking table with those PRs as the evidence links. A few asks so review on both can move quickly: - Since you noted that Java 8/11 tests and mock-backed Zeta/Flink/Spark E2E checks passed locally but live-account validation is still pending for both, please state in each PR description exactly what the mock endpoints cover (auth flow, pagination, error/empty responses) and what remains unverified against a real account. If live validation is not feasible before merge, say so explicitly so reviewers can judge the first slice on that basis. - Add a short scope statement to each PR covering what the first slice does and does not include — for PayPal, the OAuth handling, bounded date ranges, pagination, and the typed transaction record schema; for TikTok Ads, which BASIC report dimensions/metrics are read and how pagination is handled — plus anything deliberately deferred. - Make sure connector docs and tests are part of each PR, and ping here once you consider them ready for final review so they don't sit unnoticed. Once the live-account validation status is documented on the PRs, I'll pick them up for review. <!-- streview-comment:1167 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
