DanielLeens commented on issue #12332: URL: https://github.com/apache/seatunnel/issues/12332#issuecomment-5742674011
Thanks for the careful final update. I verified that current `dev` still has the failure-to-empty-map path in `RocketMqAdminUtil.currentOffsets`, so this is not fixed in `dev` yet. The corrected issue body and #12349 now describe the relevant boundary accurately: an ordinary fresh consumer group may legitimately have no retry topic and cold-start, but an inconclusive route lookup must not be translated into "no committed offsets" and a silent rewind. The PR keeps that distinction inside the admin utility, preserves the successful-empty result for newly discovered queues, and adds deterministic coverage for both branches and for the enumerator not falling back to the first offset on failure. I also confirmed that #12349's current Build is successful. The PR is still open and awaiting the remaining review/merge steps, so please keep follow-up changes and discussion on that single PR rather than opening a parallel implementation. Until it merges, this issue remains a tracked fix rather than a behavior already available on `dev`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
