SEZ9 commented on PR #12129:
URL: https://github.com/apache/seatunnel/pull/12129#issuecomment-5747161271

   Thanks for syncing with `dev` (`8d66e18f`), @akshar27 — picking up the minio 
Docker Hub mirror fix should clear the two unrelated `all-connectors-it` 
failures seen on `408f1e0`.
   
   Since the head has moved from `408f1e0` to `8d66e18f`, I'd like to re-check 
the six earlier points against the new head before this proceeds, rather than 
relying on the earlier pass over `5987eaf`/`408f1e0`:
   
   1. `NOT_YET_STARTED_STATES` wrapped in `Collections.unmodifiableSet`.
   2. Javadoc explaining why `SCHEDULED` is excluded.
   3. Null `JobStatus` in `cancelJob()`/`stopJob()` still failing fast rather 
than falling through to the `CANCELING` path.
   4. Pinning test asserting the length plus per-index ordinals with a message 
naming the drifted constant.
   5. / 6. Test Javadoc scoped to same-build protection and noting the 
mixed-version rolling-upgrade risk at the `JobStatus.values()[ordinal]` decode 
sites, with the confusing sentence cleaned up.
   
   Could you confirm those are unchanged after the sync? Once CI on `8d66e18f` 
finishes, please ping here (or note if anything unrelated still fails) and I'll 
take another look.
   
   <!-- streview-comment:1180 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to