SEZ9 commented on issue #10681: URL: https://github.com/apache/seatunnel/issues/10681#issuecomment-5747485009
Thanks for the detailed proposal — the four layers, design principles, and the priority on Layer 0 + Layer 1 are clear. A few points to align on before more implementation lands: - @junjunclub, since Layer 0 is already working for you, a first reviewable PR for Layer 0 (or Layer 0 plus the minimum Layer 1 connection checks) would help us settle the CLI boundary and failure semantics early, as suggested above. - @goutamadwant, thanks for the connector-side connectivity validation work you linked. To avoid overlapping efforts, please coordinate with @junjunclub so connector-specific checks build on one shared Layer 1 hook. - For the design itself, could you clarify how the proposed `validateConnection()` SPI should be exposed (e.g. an optional interface vs. a new method on existing factories), and how connectors that do not implement it should behave under `--dry-run=connect` (skip with a warning vs. fail)? It would also help to state whether `--dry-run` replaces the existing `--check` flag or aliases it, and how it should behave in cluster mode vs. local mode. Once those are settled, follow-up PRs can extend Layers 2 and 3. <!-- streview-comment:1188 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
