nzw921rx commented on PR #12392: URL: https://github.com/apache/seatunnel/pull/12392#issuecomment-5755807129
> @nzw921rx heads up on an overlap: this PR and your #12350 both edit `RocketMqIT.java`, so whichever lands second will need a rebase. > > This one is +30/-5 on that file, approved, CI green. #12350 is +51/-59 and currently conflicts with `dev`, probably from #12323, #12393 and #12396 landing in that file after it was opened. The two do not overlap in intent, since this change only wraps the remaining offset reads in the retry and route guard that are already in the file. If you would rather land #12350 first, I will rebase this on top of it and re-verify. > > #12349 is the same area and in the same state, approved and green, open since 09-16. It is the production fix behind #12332, and SEZ9 confirmed on 09-20 that nothing further is needed there. > Thanks for the heads-up. Please go ahead with this PR. I’ll rebase #12350 onto the latest dev afterward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
