DanielLeens commented on PR #11902:
URL: https://github.com/apache/seatunnel/pull/11902#issuecomment-5770843830
@goutamadwant Thanks for confirming — good to hear you verified this
yourself rather than just taking the earlier diagnosis on faith.
Since the target on the `apache/seatunnel-shade` side is already open
(apache/seatunnel-shade#23, `mergeable_state: clean` against its `main`), you
don't need to scope that PR from scratch — it already does exactly what we
discussed: adds `hadoop-azure:3.2.0`, includes only
`org.apache.hadoop.fs.azurebfs` classes, excludes the legacy WASB/Jetty AJAX
pieces, and merges ABFS + existing HDFS token identifier/renewer service
entries via a proper `ServicesResourceTransformer` (fixing the collision I
flagged on 2026-08-22). It also bumps the module to `3.1.4-3.0.1`. Worth
reviewing/pinging that PR along if you haven't already, since it's the actual
prerequisite gating this one.
For the concrete migration shape once `3.1.4-3.0.1` is published: here's how
the currently-merged `dev` branch already consumes this artifact, so you have a
real template rather than guessing at coordinates.
Root `pom.xml` (dependencyManagement, around line 552):
```xml
<dependency>
<groupId>org.apache.seatunnel</groupId>
<artifactId>seatunnel-shade-hadoop3-uber</artifactId>
<version>${seatunnel.shade.hadoop.version}-${seatunnel.shade.version}</version>
<scope>provided</scope>
</dependency>
```
with the version built from two properties near the top of the same file:
```xml
<seatunnel.shade.version>3.0.0</seatunnel.shade.version>
...
<seatunnel.shade.hadoop.version>3.1.4</seatunnel.shade.hadoop.version>
```
So once seatunnel-shade#23 ships as `3.1.4-3.0.1`, the only root-`pom.xml`
change needed is bumping `seatunnel.shade.version` to `3.0.1` (assuming no
other connector needs to stay pinned to `3.0.0` in the interim — worth
double-checking that before bumping the shared property).
And the connector-side dependency, taken directly from
`connector-file-hadoop/pom.xml` (the sibling module to the one you're
extending) — no version needed there since it inherits from the root's
`dependencyManagement`:
```xml
<dependency>
<groupId>org.apache.seatunnel</groupId>
<artifactId>seatunnel-shade-hadoop3-uber</artifactId>
<scope>provided</scope>
<exclusions>
<exclusion>
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
</exclusion>
</exclusions>
</dependency>
```
Your ABFS module would follow the same pattern: declare
`seatunnel-shade-hadoop3-uber` with no explicit version/`hadoop-azure`
dependency of its own, and drop the in-repo
`seatunnel-shade/seatunnel-hadoop3-3.1.4-uber` diff entirely since that module
path no longer exists on `dev`.
Once seatunnel-shade#23 is merged and released, and you've rebased this PR
on top of the new artifact (retaining both HDFS and ABFS provider tests as you
described), I'll do a full re-review end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
