DanielLeens commented on PR #12449: URL: https://github.com/apache/seatunnel/pull/12449#issuecomment-5812738750
Thanks for adding that so quickly! I re-reviewed the latest head (`cdeb970816f`) end to end, not just the diff since my last pass, and confirmed both new commits (`ae7c8e49a9e` documenting the reflective access, and `cdeb970816f` re-wrapping that comment for the Java 8 line-length check) are comment-only, don't touch any assertion or synchronization logic, and don't change the runtime behavior I already verified. `CheckpointCoordinatorFailoverIT` (all 4 tests) passed cleanly on this exact head in both the Java 8 and Java 11 `engine-v2-it` lanes. Posted a fresh full re-review below (required by our process whenever the head commit changes after an approval) — same conclusion as before: ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
