DanielLeens commented on PR #12305: URL: https://github.com/apache/seatunnel/pull/12305#issuecomment-5812778665
One small addendum to the CI diagnosis in my review above: I described `engine-v2-it (8, ubuntu-latest)`'s failure (`SplitClusterFaultToleranceIT`) but did not separately call out `engine-v2-it (11, ubuntu-latest)`, which actually fails on a different test: `CheckpointCoordinatorFailoverIT.testStreamJobFailsAfterCheckpointTriggerDispatchFailure` — an `AssertionFailedError` where the job failure got attributed to `CheckpointException: Checkpoint notify complete failed` instead of the expected `CHECKPOINT_INSIDE_ERROR` path via `CheckpointCoordinator#handleCoordinatorError`. This is a timing-dependent race between two failure-attribution paths inside `CheckpointCoordinator`/`EventService` (I also see a benign `NullPointerException: Target cannot be null!` in `EventService`'s async event-forwarder during node shutdown in the surrounding log, consistent with a shutdown-ordering race rather than a bug in this PR's diff). This PR touches no checkpoint-coordinator or event-service code , so this does not change my merge recommendation or overall assessment — just correcting the CI diagnosis to be complete and accurate rather than leaving that job uncharacterized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
