DanielLeens commented on PR #12448: URL: https://github.com/apache/seatunnel/pull/12448#issuecomment-5846298006
Thanks for running that rerun and reporting back in detail — this matches exactly what I found when I independently traced the failing jobs in my last review. The six groups you're seeing (the Windows PayPal retry-wait test, the Paimon/MinIO image pull, the Java 8 shard's `protobuf-java:3.6.1` fetch timing out against Maven Central, and the OceanBase compatibility tests) are all environmental/infra failures unrelated to this diff, not something introduced by the checkpoint fix. The fact that the checkpoint engine shards (including `CheckpointCoordinatorFailoverIT`, which was the one test in this PR's own area I'd flagged before) stay green on rerun is the strongest signal that this patch itself is solid — you were right to keep the change scoped to the checkpoint fix rather than touching anything connector- or infra-related to chase these. My approval from the last review still stands; nothing here changes that. At this point there's nothing further for you to do on the code side — this is now a question of getting a clean `Build` run (or a maintainer merging with this documented-flake context) rather than anything in your diff. I'd suggest waiting for a maintainer to either trigger one more rerun closer to merge time or move forward with the merge given how consistently these six failures point to the same known infra causes across multiple reruns. I'll keep an eye on this PR for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
